Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow start flag to be provided, skip prompts #196

Merged
merged 1 commit into from
Jun 9, 2017
Merged

✨ Allow start flag to be provided, skip prompts #196

merged 1 commit into from
Jun 9, 2017

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented May 3, 2017

Again, this is a proposal more than anything & not particularly well tested 😁

refs #194

  • if --start is provided, use that instead of prompting
  • makes it easier to call ghost install/ghost setup programmatically

@ErisDS
✨ Allow start flag to be provided, skip prompts
0411285 
refs TryGhost#194

- if --start is provided, use that instead of prompting
- makes it easier to call ghost install/ghost setup programmatically
@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.712% when pulling 0411285 on ErisDS:add-start-flag into d60d77b on TryGhost:master.

@acburdine
Copy link
Member

Because ghost install calls the ghost setup command automatically, this change will only work if you run ghost setup as a standalone command. This is due to limitations in commander.js and how it handles options, and could potentially be resolved by #179

@acburdine acburdine merged commit f663f82 into TryGhost:master Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErisDS @coveralls @acburdine